fix various iteration issues #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidanthoff
approved these changes
Jul 26, 2021
ZacLN
reviewed
Jul 26, 2021
Comment on lines
+198
to
+211
| elseif x.head === :parameters | ||
| if length(x.args) > 1 && any(a -> a.head === :parameters, x.args) | ||
| ordered_args = EXPR[] | ||
| for arg in x.args | ||
| if arg.head === :parameters | ||
| pushfirst!(ordered_args, arg) | ||
| else | ||
| push!(ordered_args, arg) | ||
| end | ||
| end | ||
| Expr(:parameters, Expr.(ordered_args)...) | ||
| else | ||
| Expr(:parameters, Expr.(x.args)...) | ||
| end |
There was a problem hiding this comment.
Not a priority right now but we shouldn't need to special case conversion so should look to fix the underlying inconsistency w/ the scheme parser
There was a problem hiding this comment.
Yeah, that's basically what I reverted here. Originally I had the right order in the EXPR, but that failed during iterate, so this was easier for me than wrapping my head around how iteration works :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two iteration order issues (kwargs with multiple
;s and things like:(;;;)) I introduced in #291.Also tests whether iteration over any of the test expressions in
test/parser.jlthrows an error.